Serialize module dependencies in swift module files #84412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
requested review from
artemcm,
hborla,
slavapestov,
tshortli,
xedin and
xymus
as code owners
adrian-prantl
requested review from
artemcm,
cachemeifyoucan and
xymus
and removed request for
artemcm,
hborla,
slavapestov,
tshortli,
xedin and
xymus
artemcm
approved these changes
Sep 23, 2025
adrian-prantl
force-pushed
the
159531233
branch
2 times, most recently
from
0a414e5 to
56bdb55
Compare
adrian-prantl
force-pushed
the
159531233
branch
from
56bdb55 to
743d554
Compare
adrian-prantl
changed the title
adrian-prantl
force-pushed
the
159531233
branch
from
743d554 to
d8df0ce
Compare
|
@swift-ci test |
|
@swift-ci test source compatibility |
adrian-prantl
force-pushed
the
159531233
branch
from
d8df0ce to
9adac78
Compare
|
(Added an escape hatch flag) |
|
@swift-ci test |
|
@swift-ci test source compatibility |
adrian-prantl
force-pushed
the
159531233
branch
from
9adac78 to
8ed4121
Compare
|
@swift-ci test |
|
@swift-ci test source compatibility |
For clients, such as the debugger, who do not have access the full output of the dependency scanner, it is a huger performance and correctness improvement if each explicitly built Swift module not just serialized all its Clang .pcm dependencies (via the serialized Clang compiler invocation) but also its direct Swift module dependencies. This patch changes the Swift module format to store the absolute path or cas cache key for each dependency in the INPUT block, and makes sure the deserialization makes these available to the ESML. rdar://150969755
adrian-prantl
force-pushed
the
159531233
branch
from
8ed4121 to
c91211a
Compare
|
@swift-ci smoke test |
|
@swift-ci test |
|
@swift-ci test macOS |
|
@swift-ci test windows |
|
Iphone simulator failures seem to fail on all recent PRs on the bot. |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For clients, such as the debugger, who do not have access the full
output of the dependency scanner, it is a huger performance and
correctness improvement if each explicitly built Swift module not just
serialized all its Clang .pcm dependencies (via the serialized Clang
compiler invocation) but also its direct Swift module dependencies.
This patch changes the Swift module format to store the absolute path
(or casid) for each dependency in the INPUT block, and makes sure
the deserialization makes these available to the ESML.
rdar://150969755